Project

General

Profile

Bug #29

Apply old memory leak patch

Added by ronald - about 16 years ago. Updated almost 16 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Mulgara
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
fixed

Description

The Fedora folks found and a fixed a memory leak in Kowari 1.0.5. It
<br/>
looks like this patch is still needed. See also
<br/>
[<a href="http://prototypo.blogspot.com/2005/09/kowari-memory-leak-found-and-fixed.html">http://prototypo.blogspot.com/2005/09/kowari-memory-leak-found-and-fixed.html</a>]
<br/>
Here is the one-line patch against Mulgara svn head:
<br/>

<br/>
-----------------------------------------------------------------
<br/>
Index: src/jar/util-xa/java/org/mulgara/store/xa/FreeList.java
<br/>
===================================================================
<br/>
--- src/jar/util-xa/java/org/mulgara/store/xa/FreeList.java    (revision <a href="http://mulgara.org/trac/changeset/106">106</a>)
<br/>
+++ src/jar/util-xa/java/org/mulgara/store/xa/FreeList.java    (working copy)
<br/>
@@ -1070,6 +1070,7 @@
<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;public Phase() throws IOException {
<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;synchronized (FreeList.this) {
<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;if (currentPhase != null) {
<br/>
+          removeClosedPhases();
<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;sequenceNumber = currentPhase.sequenceNumber + 1;
<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;head = currentPhase.head;
<br/>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;tail = currentPhase.tail;
<br/>
-----------------------------------------------------------------
<br/>

#1

Updated by Paula Gearon about 16 years ago

Good catch.
<br/>

<br/>
I hadn't looked at this fix before, but this is indeed missing.  Running tests now.

Also available in: Atom PDF